Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert monster opts #69399

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Revert monster opts #69399

merged 2 commits into from
Nov 15, 2023

Conversation

akrieger
Copy link
Member

@akrieger akrieger commented Nov 15, 2023 •
edited
Loading

Summary

None

Purpose of change

Fixes #69396. Too many issues, backing out to a clean state per PR authors request.

Describe the solution

Reverts to what used to work.

Describe alternatives you've considered

Fixing forward.

Testing

SCM backout was clean.

Additional context

@github-actions github-actions bot added NPC / Factions NPCs, AI, Speech, Factions, Ownership [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Nov 15, 2023
@akrieger
Back out "Move remove_creature_from_reachability calls from the destr…
56c4952 
…uctor to on_unload. The avatar never unloads."

Original commit changeset: e8f77ab
@akrieger
Back out "Performance: Optimize monster planning"
0235dfe 
Original commit changeset: f79a631
@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 15, 2023
@Maleclypse Maleclypse merged commit 46d3b7f into CleverRaven:master Nov 15, 2023
25 checks passed
Maleclypse pushed a commit to Maleclypse/Cataclysm-DDA that referenced this pull request Nov 16, 2023
@akrieger @Maleclypse
Revert monster opts (CleverRaven#69399)
94f53b8 
* Back out "Move remove_creature_from_reachability calls from the destructor to on_unload. The avatar never unloads."

Original commit changeset: e8f77ab

* Back out "Performance: Optimize monster planning"

Original commit changeset: f79a631
@prharvey prharvey mentioned this pull request Nov 20, 2023
Merged
@akrieger akrieger deleted the revert_monster_opts branch May 31, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash upon killing enemy, segmentation fault
2 participants
@akrieger @Maleclypse